On Thu, Dec 20, 2018 at 07:43:35PM -0800, Florian Fainelli wrote:
> Hi all,
>
> I just painfully learned that perf would segfault when
> CONFIG_KUSER_HELPERS is disabled because it unconditionally makes use of
> it. This patch series adds an ARM test for that by leveraging the
> existing find_vdso_map() function and making it more generic and capable
> of location any map within /proc/self/maps.
>
> Changes in v3:
>
> - remove find_vdso_map() call find_map() with VDSO__MAP_NAME
>
> Changes in v2:
>
> - use strlen() instead of sizeof() -1 since we made the page name a
> parameter
> - use TEST_OK/TEST_FAIL in lieu of 0/-1
> - added an error message indicating CONFIG_KUSER_HELPERS might be
> disabled
>
> Florian Fainelli (2):
> perf tools: Make find_vdso_map() more modular
> perf tests: Add a test for the ARM 32-bit [vectors] page
Acked-by: Jiri Olsa <jo...@kernel.org>
thanks,
jirka
>
> tools/perf/Makefile.perf | 4 ++--
> tools/perf/arch/arm/tests/Build | 1 +
> tools/perf/arch/arm/tests/arch-tests.c | 4 ++++
> tools/perf/arch/arm/tests/vectors-page.c | 24 +++++++++++++++++++
> tools/perf/perf-read-vdso.c | 6 ++---
> tools/perf/tests/tests.h | 5 ++++
> .../perf/util/{find-vdso-map.c => find-map.c} | 7 +++---
> tools/perf/util/vdso.c | 6 ++---
> 8 files changed, 45 insertions(+), 12 deletions(-)
> create mode 100644 tools/perf/arch/arm/tests/vectors-page.c
> rename tools/perf/util/{find-vdso-map.c => find-map.c} (71%)
>
> --
> 2.17.1
>
