From: Peng Hao <[email protected]> Date: Thu, 3 Jan 2019 01:09:53 +0800
> From: Wen Yang <[email protected]> > > Currently there are some issues with the ucc_of_parse_tdm function: > 1, a possible null pointer dereference in ucc_of_parse_tdm, > detected by the semantic patch deref_null.cocci, > with the following warning: > drivers/soc/fsl/qe/qe_tdm.c:177:21-24: ERROR: pdev is NULL but dereferenced. > 2, dev gets modified, so in any case that devm_iounmap() will fail > even when the new pdev is valid, because the iomap was done with a > different pdev. > 3, there is no driver bind with the "fsl,t1040-qe-si" or > "fsl,t1040-qe-siram" device. So allocating resources using devm_*() > with these devices won't provide a cleanup path for these resources > when the caller fails. > > This patch fixes them. > > Suggested-by: Li Yang <[email protected]> > Suggested-by: Christophe LEROY <[email protected]> > Signed-off-by: Wen Yang <[email protected]> > Reviewed-by: Peng Hao <[email protected]> Applied, thanks.
