On Mon, Jan 07, 2019 at 10:50:39AM -0800, r...@google.com wrote: > From: Roman Kiryanov <r...@google.com> > > The Goldfish sync driver is designed to provide a interface > between the underlying host's sync device and the kernel's > fence sync framework. > > Signed-off-by: Roman Kiryanov <r...@google.com> > --- > Changes in v2: > - Added a missing include (mod_devicetable.h). > - Put in one batch with goldfish_address_space.c to avoid merge comflicts.
You have a number of WARN_ON() calls in here that are not needed, please remove. Also, why is this driver needed at all? Why can't you use the "normal" drm sync api interface? Why write a custom ioctl driver just for this one kernel interface? thanks, greg k-h
