On Tue, Jan 8, 2019 at 8:10 AM Enric Balletbo i Serra <[email protected]> wrote: > > None of these are required at the moment. > > Signed-off-by: Enric Balletbo i Serra <[email protected]> > --- > > drivers/platform/chrome/cros_ec_vbc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec_vbc.c > b/drivers/platform/chrome/cros_ec_vbc.c > index af9bfe6f385c..86903bc31b27 100644 > --- a/drivers/platform/chrome/cros_ec_vbc.c > +++ b/drivers/platform/chrome/cros_ec_vbc.c > @@ -18,10 +18,8 @@ > * GNU General Public License for more details. > */ > > -#include <linux/of.h> > #include <linux/platform_device.h> > #include <linux/mfd/cros_ec.h> > -#include <linux/mfd/cros_ec_commands.h>
It is customary to not rely on secondary includes. Yet, with this removal, the code will rely on cros_ec.h including cros_ec_commands.h, for the definition of EC_VBNV_CONTEXT_OP_READ. Does this really make sense ? [ I didn't check the other patches, but I suspect the same applies there as well ] Guenter > #include <linux/module.h> > #include <linux/slab.h> > > -- > 2.20.1 >
