Re: [PATCH V5 2/2] kobject: drop newline from msg string

[YU Bo]

On Wed, Jan 09, 2019 at 10:21:37AM +0100, Rafael J. Wysocki wrote:

On Wed, Jan 9, 2019 at 10:17 AM Bo YU <tsu.y...@gmail.com> wrote:

There is currently a missing terminating newline in non-switch case
match when msg == NULL

Signed-off-by: Bo YU <tsu.y...@gmail.com>

I have given you an R-by for this one already, so why haven't you added it here?

Oh, i got it.This is the first time i encountered the circumstances.

Reviewed-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com>

Thank you :)

---
Changes in V4:
Recovery originly declaration, requested by Greg.

Change in V3:
Improve the commit log, requested by Rafael.

Changes in V2:
Drop newline from msg according to Joe's suggestion.
---
 lib/kobject_uevent.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
index c87a96c4800e..f05802687ba4 100644
--- a/lib/kobject_uevent.c
+++ b/lib/kobject_uevent.c
@@ -200,7 +200,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char 
*buf, size_t count)

        r = kobject_action_type(buf, count, &action, &action_args);
        if (r) {
-               msg = "unknown uevent action string\n";
+               msg = "unknown uevent action string";
                goto out;
        }

@@ -212,7 +212,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char 
*buf, size_t count)
        r = kobject_action_args(action_args,
                                count - (action_args - buf), &env);
        if (r == -EINVAL) {
-               msg = "incorrect uevent action arguments\n";
+               msg = "incorrect uevent action arguments";
                goto out;
        }

@@ -224,7 +224,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char 
*buf, size_t count)
 out:
        if (r) {
                devpath = kobject_get_path(kobj, GFP_KERNEL);
-               pr_warn("synth uevent: %s: %s",
+               pr_warn("synth uevent: %s: %s\n",
                       devpath ?: "unknown device",
                       msg ?: "failed to send uevent");
                kfree(devpath);
--
2.11.0