On Sun, 29 Jul 2007 10:53:39 +0800,
Eugene Teo <[EMAIL PROTECTED]> wrote:
> @@ -388,20 +389,34 @@ void add_partition(struct gendisk *disk, int part,
> sector_t start, sector_t len,
> p->kobj.parent = &disk->kobj;
> p->kobj.ktype = &ktype_part;
> kobject_init(&p->kobj);
> - kobject_add(&p->kobj);
> + err = kobject_add(&p->kobj);
> + if (err)
> + goto err_out;
> if (!disk->part_uevent_suppress)
> kobject_uevent(&p->kobj, KOBJ_ADD);
> - sysfs_create_link(&p->kobj, &block_subsys.kobj, "subsystem");
> + err = sysfs_create_link(&p->kobj, &block_subsys.kobj, "subsystem");
> + if (err)
> + goto err_out_del_kobj;
> if (flags & ADDPART_FLAG_WHOLEDISK) {
> static struct attribute addpartattr = {
> .name = "whole_disk",
> .mode = S_IRUSR | S_IRGRP | S_IROTH,
> };
>
> - sysfs_create_file(&p->kobj, &addpartattr);
> + err = sysfs_create_file(&p->kobj, &addpartattr);
> + if (err)
> + goto err_out_del_link;
> }
> partition_sysfs_add_subdir(p);
> disk->part[part-1] = p;
> + return;
> +
> +err_out_del_link:
> + sysfs_remove_link(&p->kobj, "subsystem");
You need a remove uevent if you did an add uevent above.
> +err_out_del_kobj:
> + kobject_del(&p->kobj);
> +err_out:
> + kfree(p);
Please use kobject_put() instead.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
