Cornelia Huck wrote:
> On Mon, 30 Jul 2007 17:47:55 +0800,
> Eugene Teo <[EMAIL PROTECTED]> wrote:
>
>> +err_out_del_link:
>> + sysfs_remove_link(&p->kobj, "subsystem");
>> +err_out_del_kobj:
>> + if (!disk->part_uevent_suppress)
>> + kobject_uevent(&p->kobj, KOBJ_REMOVE);
>> + kobject_put(&p->kobj);
>> +err_out:
>> + kfree(p);
>> }
>
> No, this is wrong. You need to move the put behind err_out and remove
> the kfree. (The release function will take care of p.)
503 void kobject_put(struct kobject * kobj)
504 {
505 if (kobj)
506 kref_put(&kobj->kref, kobject_release);
[...]
52 int kref_put(struct kref *kref, void (*release)(struct kref *kref))
53 {
[...]
57 if (atomic_dec_and_test(&kref->refcount)) {
58 release(kref);
59 return 1;
Nod, thanks for your guidance.
Eugene
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
