Hi Balbir,
> diff -puN mm/memcontrol.c~mem-control-lru-and-reclaim mm/memcontrol.c
> --- linux-2.6.23-rc1-mm1/mm/memcontrol.c~mem-control-lru-and-reclaim
> 2007-07-28 01:12:50.000000000 +0530
> +++ linux-2.6.23-rc1-mm1-balbir/mm/memcontrol.c 2007-07-28
> 01:12:50.000000000 +0530
> /*
> * The memory controller data structure. The memory controller controls both
> @@ -51,6 +54,10 @@ struct mem_container {
> */
> struct list_head active_list;
> struct list_head inactive_list;
> + /*
> + * spin_lock to protect the per container LRU
> + */
> + spinlock_t lru_lock;
> };
The spinlock is not annotated by lockdep. The following patch should do
it.
Signed-off-by: Dhaval Giani <[EMAIL PROTECTED]>
Signed-off-by: Gautham Shenoy R <[EMAIL PROTECTED]>
Index: linux-2.6.23-rc1/mm/memcontrol.c
===================================================================
--- linux-2.6.23-rc1.orig/mm/memcontrol.c 2007-07-30 17:27:24.000000000
+0530
+++ linux-2.6.23-rc1/mm/memcontrol.c 2007-07-30 18:43:40.000000000 +0530
@@ -501,6 +501,9 @@
static struct mem_container init_mem_container;
+/* lockdep should know about lru_lock */
+static struct lock_class_key lru_lock_key;
+
static struct container_subsys_state *
mem_container_create(struct container_subsys *ss, struct container *cont)
{
@@ -519,6 +522,7 @@
INIT_LIST_HEAD(&mem->active_list);
INIT_LIST_HEAD(&mem->inactive_list);
spin_lock_init(&mem->lru_lock);
+ lockdep_set_class(&mem->lru_lock, &lru_lock_key);
mem->control_type = MEM_CONTAINER_TYPE_ALL;
return &mem->css;
}
--
regards,
Dhaval
I would like to change the world but they don't give me the source code!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
