On Wed, Dec 12, 2018 at 12:37:09PM +0100, Greg Kroah-Hartman wrote: > On Fri, Dec 07, 2018 at 08:47:21PM -0500, Kyle Williams wrote: > > From: Kyle Williams <kdgw...@chromium.org> > > > > Description: enable the ability to disable LPM for all devices matched > > by interface information > > Why have "Description:" in here? Of course this is the description :) > > And the subject doesn't make much sense, what does this have to do with > quirks? > > Also, you need more information here in the description about why you > are doing all of this, as it is, I have no idea why this patch is needed > at all. > > thanks, > > greg k-h
It seems the underlying issue has been solved in 0472bf0 xhci: Prevent U1/U2 link pm states if exit latency is too long However, the patch to fix the issue when matching the USB_QUIRK_NO_LPM quirk by iterface could be useful in the future. Currently nothing will happen that quirk is matched by interface instead of by vid/pid pair. Is their anything that would need to be changed besides removing the Description tag? -Kyle
