On 1/10/19 4:26 PM, Vineet Gupta wrote:
> | > Also, set_mask_bits is used in fs quite a bit and we can possibly come up
> | > with a generic llsc based implementation (w/o the cmpxchg loop)
> |
> | May I also suggest changing the return value of set_mask_bits() to old.
> |
> | You can compute the new value given old, but you cannot compute the old
> | value given new, therefore old is the better return value. Also, no
> | current user seems to use the return value, so changing it is without
> | risk.
>
> Link:
> http://lkml.kernel.org/g/[email protected]
> Suggested-by: Peter Zijlstra <[email protected]>
> Cc: Miklos Szeredi <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Cc: Jani Nikula <[email protected]>
> Cc: Chris Wilson <[email protected]>
> Cc: Andrew Morton <[email protected]>
> Cc: Will Deacon <[email protected]>
> Signed-off-by: Vineet Gupta <[email protected]>
>
Reviewed-by: Anthony Yznaga <[email protected]>
