On Tue, Jan 08, 2019 at 01:38:34AM -0800, Atish Patra wrote: > It is perfectly okay to call riscv_hartid_to_cpuid for a > hartid that is not mapped with an CPU id. It can happen > if the calling functions retrieves the hartid from DT. > However, that hartid was never brought online by the firmware > or kernel for any reasons. > > No need to BUG() in the above case. A negative error return > is sufficient and the calling function should check for the > return value always. > > Signed-off-by: Atish Patra <[email protected]>
Looks fine (modulo the line length issues): Reviewed-by: Christoph Hellwig <[email protected]>
