On Thu, Dec 27, 2018 at 04:48:18PM +0530, Anup Patel wrote: > The plic_toggle() uses raw_spin_lock() and plic_irq_toggle has a > for loop so both these functions are not suitable for being inline > hence this patch removes the inline keyword.
That is a weird argument for a function which has by design exactly two callers and is in the hot path. The alternative to the inline here would be to duplicate the code.

