On 1/17/2019 12:55 AM, Borislav Petkov wrote: > On Wed, Jan 16, 2019 at 03:10:40PM +0000, S, Shirish wrote: >> MC4_MISC thresholding quirk needs to be applied during S5 -> S0 and >> S3 -> S0 state transitions, which follow different code paths, hence >> carve it out and move it mce_amd_feature_init(), which is the converging >> point of both code paths. >> >> Changelog[v2]: >> - move the quirk to mce/amd.c > For future reference: changelog lines ... > >> Signed-off-by: Shirish S <shiris...@amd.com> >> --- > ... land below this line so that they are not part of the commit > message. Understood. >> arch/x86/kernel/cpu/mce/amd.c | 34 ++++++++++++++++++++++++++++++++++ >> arch/x86/kernel/cpu/mce/core.c | 29 ----------------------------- >> 2 files changed, 34 insertions(+), 29 deletions(-) >> >> diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c >> index 89298c8..f6a5c96 100644 >> --- a/arch/x86/kernel/cpu/mce/amd.c >> +++ b/arch/x86/kernel/cpu/mce/amd.c >> @@ -545,6 +545,33 @@ prepare_threshold_block(unsigned int bank, unsigned int >> block, u32 addr, >> return offset; >> } >> >> +void mc4_misc_thresholding_quirk(void) > Functions should have a verb in their names. > > I've fixed those and other issues now but make sure you take a look at > those nice documents here, for future reference, when preparing other > patches: > > https://www.kernel.org/doc/html/latest/process/index.html
Thanks for the support, i shall follow the practice from next patch onwards. Regards, Shirish S > Thx. > -- Regards, Shirish S
