On Tue, 31 Jul 2007, WANG Cong wrote:
> On Tue, Jul 31, 2007 at 08:00:12PM +0530, Satyam Sharma wrote: > > [...] > >It better not be, else we have a bug already anyway. Pointers are 64-bit > >on 64-bit archs. [ it turns out res->start is resource_size_t which is > >set properly as per CONFIG_RESOURCES_64BIT which itself is set properly > >as per CONFIG_64BIT, so everything is healthy and fine :-) ] > > > > I agree. > > However, I think using resource_size_t is a bit better than unsigned long, > so that we don't need to check the defination of it. > > - res->start = (unsigned long)kmalloc(*size, GFP_KERNEL); > + res->start = (resource_size_t)kmalloc(*size, GFP_KERNEL); > > Is this change OK? Yes, that would probably be clearer. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
