On 1/17/19 7:50 AM, Miquel Raynal wrote: > Hi Andrew, Vivien, > > Vivien Didelot <vivien.dide...@gmail.com> wrote on Thu, 17 Jan 2019 > 10:46:41 -0500: > >> Hi, >> >> On Wed, 16 Jan 2019 23:23:29 +0100, Andrew Lunn <and...@lunn.ch> wrote: >>> Hi Florian >>> >>>> A possible approach could be to call the port_disable, port_enable >>>> callbacks from dsa_slave_suspend() and dsa_slave_resume(), I might have >>>> some patches doing that already somewhere. >>> >>> I expect it is also on Viviens TODO list, since this really could be >>> in the core. >> >> Indeed that is! > > So, shall I wait for Vivien's patches (adding port_disable/enable() > in dsa_slave_suspend/resume()) and keep the driver as-is or do you want > me to manually call port_disable/enable() from the mv88e6xxx driver?
Up to you guys, the only thing that I an tell you is that my platform loses its register contents during suspend/resume, therefore you must make sure the driver re-applies the entire switch configuration, identical to how it was prior to suspend. If you need me to test something, please holler. -- Florian
