> On Fri, 27 Jul 2007, Andrew Patterson wrote: > > > On Thu, 2007-07-26 at 23:23 -0700, Andrew Vasquez wrote: > > > > > The 33/66/100/133 values refer to the bus-clock speed at which the > > > card is operating. As is seen here (although a bit truncated -- > > > separate issue, I'll try to see if I can reproduce this on one of my > > > HPQ rigs), the card is inserted into a PCI-X Mode-2 capable 133MHz > > > (bus clock) slot. When operating under this mode, each data-phase > > > between two devices is divided into 2 sub-phases, effectively doubling > > > the transfer-data-rate to 266Mhz. > > > > I guess the proper terminology would be 266 MT/s (Mega > > Transfers/second). Looking through the PSI_SIG PCI-X 2.0 marketing > > blurbs, they use MHz a lot when referring to MT/S. So I would still > > consider this to be a minor bug. The user wants to know the transfer > > rate, not the actual frequency of the bus. Maybe just print out the > > mode used instead, e.g., "PCI-X 266"?
Given PCI-X Mode-2 can run at different bus-clock speeds, how about this as an alternative? PCI-X 266 (133Mhz) it's a bit more descriptive than PCI-X Mode 2 (133Mhz) then again, I don't want to beat this thing to death... --- diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index c488996..26f7e54 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -283,9 +283,9 @@ qla24xx_pci_info_str(struct scsi_qla_host *ha, char *str) } else { strcat(str, "-X "); if (pci_bus & BIT_2) - strcat(str, "Mode 2"); + strcat(str, "266"); else - strcat(str, "Mode 1"); + strcat(str, "133"); strcat(str, " ("); strcat(str, pci_bus_modes[pci_bus & ~BIT_2]); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/