On Mon, Jan 07, 2019 at 08:54:27PM +0300, Vitaly Chikunov wrote: > Before this, if akcipher_testvec have `public_key_vec' set to true > (i.e. having a public key) only sign/encrypt test is performed, but > verify/decrypt test is skipped. > > With a public key we could do encrypt and verify, but to sign and decrypt > a private key is required. > > This logic is correct for encrypt/decrypt tests (decrypt is skipped if > no private key). But incorrect for sign/verify tests - sign is performed > no matter if there is no private key, but verify is skipped if there is > a public key. > > Rework `test_akcipher_one' to arrange tests properly depending on value > of `public_key_vec` and `siggen_sigver_test'. > > No tests were missed since there is only one sign/verify test (which > have `siggen_sigver_test' set to true) and it has a private key, but > future tests could benefit from this improvement. > > Signed-off-by: Vitaly Chikunov <v...@altlinux.org> > --- > crypto/testmgr.c | 86 > +++++++++++++++++++++++++++++++++++++------------------- > 1 file changed, 57 insertions(+), 29 deletions(-)
Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
