On 1/17/19 1:45 AM, Seeteena Thoufeek wrote:
> +from __future__ import print_function
You don't need this unless you're actually requiring functionality that only
exists in v3.
For example, you need it to handle the suppress newline functionality such as
"end=".
> def print_error_totals():
> if for_comm is not None:
> - print "\nsyscall errors for %s:\n\n" % (for_comm),
> + print("\nsyscall errors for %s:\n\n" % (for_comm)),
> else:
> - print "\nsyscall errors:\n\n",
> + print("\nsyscall errors:\n\n"),
>
> - print "%-30s %10s\n" % ("comm [pid]", "count"),
> - print "%-30s %10s\n" % ("------------------------------", \
> - "----------"),
> + print("%-30s %10s\n" % ("comm [pid]", "count")),
> + print("%-30s %10s\n" % ("------------------------------", \
> + "----------")),
Same comments as before regarding trailing comma for function.
See:
https://build.opensuse.org/package/view_file/devel:tools/perf/port-failed-syscalls-by-pid-script-to-python3.patch?expand=1
