When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Anil Gurumurthy <anil.gurumur...@qlogic.com>
Cc: Sudarsana Kalluru <sudarsana.kall...@qlogic.com>
Cc: "James E.J. Bottomley" <j...@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.peter...@oracle.com>
Cc: linux-s...@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
---
 drivers/scsi/bfa/bfad_debugfs.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/drivers/scsi/bfa/bfad_debugfs.c b/drivers/scsi/bfa/bfad_debugfs.c
index 349cfe7d055e..ece165851cf6 100644
--- a/drivers/scsi/bfa/bfad_debugfs.c
+++ b/drivers/scsi/bfa/bfad_debugfs.c
@@ -460,11 +460,6 @@ bfad_debugfs_init(struct bfad_port_s *port)
        if (!bfa_debugfs_root) {
                bfa_debugfs_root = debugfs_create_dir("bfa", NULL);
                atomic_set(&bfa_debugfs_port_count, 0);
-               if (!bfa_debugfs_root) {
-                       printk(KERN_WARNING
-                               "BFA debugfs root dir creation failed\n");
-                       goto err;
-               }
        }
 
        /* Setup the pci_dev debugfs directory for the port */
@@ -472,12 +467,6 @@ bfad_debugfs_init(struct bfad_port_s *port)
        if (!port->port_debugfs_root) {
                port->port_debugfs_root =
                        debugfs_create_dir(name, bfa_debugfs_root);
-               if (!port->port_debugfs_root) {
-                       printk(KERN_WARNING
-                               "bfa %s: debugfs root creation failed\n",
-                               bfad->pci_name);
-                       goto err;
-               }
 
                atomic_inc(&bfa_debugfs_port_count);
 
@@ -489,12 +478,6 @@ bfad_debugfs_init(struct bfad_port_s *port)
                                                        port->port_debugfs_root,
                                                        port,
                                                        file->fops);
-                       if (!bfad->bfad_dentry_files[i]) {
-                               printk(KERN_WARNING
-                                       "bfa %s: debugfs %s creation failed\n",
-                                       bfad->pci_name, file->name);
-                               goto err;
-                       }
                }
        }
 
-- 
2.20.1

Reply via email to