On Tue, Jan 22, 2019 at 06:44:38PM +0000, Robin Murphy wrote: > Hi Greg, > > On 22/01/2019 15:21, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something different based on this. > > > > Also delete the variables for the file dentries for the debugfs entries > > as they are never used at all once they are created. > > Modulo one nit below, I certainly approve of the cleanup :) > > Reviewed-by: Robin Murphy <robin.mur...@arm.com> > > > Cc: Christoph Hellwig <h...@lst.de> > > Cc: Marek Szyprowski <m.szyprow...@samsung.com> > > Cc: Robin Murphy <robin.mur...@arm.com> > > Cc: io...@lists.linux-foundation.org > > Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> > > --- > > kernel/dma/debug.c | 81 ++++++---------------------------------------- > > 1 file changed, 10 insertions(+), 71 deletions(-) > > > > diff --git a/kernel/dma/debug.c b/kernel/dma/debug.c > > index 23cf5361bcf1..2f5fc8b9d39f 100644 > > --- a/kernel/dma/debug.c > > +++ b/kernel/dma/debug.c > > @@ -136,14 +136,6 @@ static u32 nr_prealloc_entries = > > PREALLOC_DMA_DEBUG_ENTRIES; > > /* debugfs dentry's for the stuff above */ > > static struct dentry *dma_debug_dent __read_mostly; > > Does this actually need to be at file scope, or could it be punted to a > local in dma_debug_fs_init() while we're here?
It can be moved to the function scope if you want me to, I was trying to do the least needed here :) thanks, greg k-h
