On 22-01-19, 16:21, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Viresh Kumar <vire...@kernel.org> > Cc: Nishanth Menon <n...@ti.com> > Cc: Stephen Boyd <sb...@kernel.org> > Cc: linux...@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> > --- > drivers/opp/core.c | 10 +--- > drivers/opp/debugfs.c | 109 +++++++++++------------------------------- > drivers/opp/opp.h | 15 +++--- > 3 files changed, 37 insertions(+), 97 deletions(-)
Applied with following changes. Thanks Greg. diff --git a/drivers/opp/core.c b/drivers/opp/core.c index 91d15c58eae1..d455b84cce5a 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.c @@ -793,7 +793,6 @@ static struct opp_device *_add_opp_dev_unlocked(const struct device *dev, struct opp_table *opp_table) { struct opp_device *opp_dev; - int ret; opp_dev = kzalloc(sizeof(*opp_dev), GFP_KERNEL); if (!opp_dev) diff --git a/drivers/opp/debugfs.c b/drivers/opp/debugfs.c index baac1ae33c55..a1c57fe14de4 100644 --- a/drivers/opp/debugfs.c +++ b/drivers/opp/debugfs.c @@ -93,7 +93,8 @@ void opp_debug_create_one(struct dev_pm_opp *opp, struct opp_table *opp_table) debugfs_create_bool("suspend", S_IRUGO, d, &opp->suspend); debugfs_create_u32("performance_state", S_IRUGO, d, &opp->pstate); debugfs_create_ulong("rate_hz", S_IRUGO, d, &opp->rate); - debugfs_create_ulong("clock_latency_ns", S_IRUGO, d, &opp->clock_latency_ns); + debugfs_create_ulong("clock_latency_ns", S_IRUGO, d, + &opp->clock_latency_ns); opp_debug_create_supplies(opp, opp_table, d); -- viresh