On Mon, Jan 21, 2019 at 11:24:55AM -0500, Jerome Glisse wrote: > On Mon, Jan 21, 2019 at 03:57:02PM +0800, Peter Xu wrote: > > This is the gup counterpart of the change that allows the VM_FAULT_RETRY > > to happen for more than once. > > > > Signed-off-by: Peter Xu <pet...@redhat.com> > > So it would be nice to add a comment in the code and in the commit message > about possible fault starvation (mostly due to previous patch changes) as > if some one experience that and try to bisect it might overlook the commit. > > Otherwise: > > Reviewed-by: Jérôme Glisse <jgli...@redhat.com>
Jerome, can I still keep this r-b if I'm going to fix the starvation issue you mentioned in previous patch about lock page? Regards, -- Peter Xu
