Re: [PATCH] misc: aspeed-lpc-ctrl: Correct return values

[Vijay Khemka]

On 1/24/19, 12:16 AM, "Greg Kroah-Hartman" <gre...@linuxfoundation.org> wrote:

    On Wed, Jan 23, 2019 at 03:06:34PM -0800, Vijay Khemka wrote:
    > Corrected some of return values with appropriate meanings.
    > 
    > Signed-off-by: Vijay Khemka <vijaykhe...@fb.com>
    > ---
    >  drivers/misc/aspeed-lpc-ctrl.c | 15 +++++++--------
    >  1 file changed, 7 insertions(+), 8 deletions(-)
    > 
    > diff --git a/drivers/misc/aspeed-lpc-ctrl.c 
b/drivers/misc/aspeed-lpc-ctrl.c
    > index 332210e06e98..97ae341109d5 100644
    > --- a/drivers/misc/aspeed-lpc-ctrl.c
    > +++ b/drivers/misc/aspeed-lpc-ctrl.c
    > @@ -68,7 +68,6 @@ static long aspeed_lpc_ctrl_ioctl(struct file *file, 
unsigned int cmd,
    >           unsigned long param)
    >  {
    >   struct aspeed_lpc_ctrl *lpc_ctrl = file_aspeed_lpc_ctrl(file);
    > - struct device *dev = file->private_data;
    >   void __user *p = (void __user *)param;
    >   struct aspeed_lpc_ctrl_mapping map;
    >   u32 addr;
    > @@ -93,8 +92,8 @@ static long aspeed_lpc_ctrl_ioctl(struct file *file, 
unsigned int cmd,
    >  
    >           /* If memory-region is not described in device tree */
    >           if (!lpc_ctrl->mem_size) {
    > -                 dev_err(dev, "Didn't find reserved memory\n");
    > -                 return -EINVAL;
    > +                 pr_err("aspeed_lpc_ctrl: ioctl: Didn't find reserved 
memory\n");
    
    Why did you change from dev_err() to pr_err()?  You just lost a lot of
    information that the user previously was getting from dev_err() :(

I did this as per review comment from Andrew Jeffery, as we don't want to put 
this error for driver. It has to be handled by userspace. But I am still 
reporting some error here.
    
    
    
    > +                 return -ENXIO;
    >           }
    >  
    >           map.size = lpc_ctrl->mem_size;
    > @@ -134,16 +133,16 @@ static long aspeed_lpc_ctrl_ioctl(struct file 
*file, unsigned int cmd,
    >  
    >           if (map.window_type == ASPEED_LPC_CTRL_WINDOW_FLASH) {
    >                   if (!lpc_ctrl->pnor_size) {
    > -                         dev_err(dev, "Didn't find host pnor flash\n");
    > -                         return -EINVAL;
    > +                         pr_err("aspeed_lpc_ctrl: ioctl: Didn't find 
host pnor flash\n");
    
    Again, don't do that :(
    
    thanks,
    
    greg k-h