Re: [PATCH] mm,memory_hotplug: Fix scan_movable_pages for gigantic hugepages

[Oscar Salvador]

On Wed, Jan 23, 2019 at 11:33:56AM +0100, David Hildenbrand wrote:
> If you use {} for the else case, please also do so for the if case.

Diff on top:

diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 25aee4f04a72..d5810e522b72 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -1338,9 +1338,9 @@ static unsigned long scan_movable_pages(unsigned long 
start, unsigned long end)
                                struct page *head = compound_head(page);
 
                                if 
(hugepage_migration_supported(page_hstate(head)) &&
-                                   page_huge_active(head))
+                                   page_huge_active(head)) {
                                        return pfn;
-                               else {
+                               } else {
                                        unsigned long skip;
 
                                        skip = (1 << compound_order(head)) - 
(page - head);

> Apart from that this looks good to me
> 
> Reviewed-by: David Hildenbrand <da...@redhat.com>

Thanks David ;-)

-- 
Oscar Salvador
SUSE L3