On Sat, Jan 26, 2019 at 9:31 AM Gustavo A. R. Silva <gust...@embeddedor.com> wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > lib/cmdline.c:137:7: warning: this statement may fall through > [-Wimplicit-fallthrough=] > lib/cmdline.c:140:7: warning: this statement may fall through > [-Wimplicit-fallthrough=] > lib/cmdline.c:143:7: warning: this statement may fall through > [-Wimplicit-fallthrough=] > lib/cmdline.c:146:7: warning: this statement may fall through > [-Wimplicit-fallthrough=] > lib/cmdline.c:149:7: warning: this statement may fall through > [-Wimplicit-fallthrough=] > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com>
Acked-by: Kees Cook <keesc...@chromium.org> -Kees > --- > lib/cmdline.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/lib/cmdline.c b/lib/cmdline.c > index 171c19b6888e..dc59d6216318 100644 > --- a/lib/cmdline.c > +++ b/lib/cmdline.c > @@ -135,18 +135,23 @@ unsigned long long memparse(const char *ptr, char > **retptr) > case 'E': > case 'e': > ret <<= 10; > + /* fall through */ > case 'P': > case 'p': > ret <<= 10; > + /* fall through */ > case 'T': > case 't': > ret <<= 10; > + /* fall through */ > case 'G': > case 'g': > ret <<= 10; > + /* fall through */ > case 'M': > case 'm': > ret <<= 10; > + /* fall through */ > case 'K': > case 'k': > ret <<= 10; > -- > 2.20.1 > -- Kees Cook
