Re: [PATCH][next] mtd: rawnand: meson: fix missing assignment of ret on a call to meson_chip_buffer_init

[Liang Yang]

Hello Colin,

On 2019/1/29 18:57, Colin King wrote:

From: Colin Ian King <colin.k...@canonical.com>

The call to meson_chip_buffer_init is not assigning ret, however, ret
is being checked for failure. Fix this by adding in the missing assignment.

ok. thanks for your time.

Fixes: 2d570b34b41a ("mtd: rawnand: meson: add support for Amlogic NAND flash 
controller")
Signed-off-by: Colin Ian King <colin.k...@canonical.com>
---
  drivers/mtd/nand/raw/meson_nand.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/raw/meson_nand.c 
b/drivers/mtd/nand/raw/meson_nand.c
index e858d58d97b0..b9c543d1054c 100644
--- a/drivers/mtd/nand/raw/meson_nand.c
+++ b/drivers/mtd/nand/raw/meson_nand.c
@@ -1206,7 +1206,7 @@ static int meson_nand_attach_chip(struct nand_chip *nand)
                dev_err(nfc->dev, "16bits bus width not supported");
                return -EINVAL;
        }
-       meson_chip_buffer_init(nand);
+       ret = meson_chip_buffer_init(nand); >        if (ret)
                return -ENOMEM;