On Tue, Jan 29, 2019 at 08:02:37PM +0100, Geert Uytterhoeven wrote: > Hi Boris, > > On Fri, Jan 18, 2019 at 11:07 PM Boris Brezillon <bbrezil...@kernel.org> > wrote: > > Did you consider converting this driver to spimem? Looks like the > > protocol used to communicate with the memory resembles the one used on > > SPI NANDs/NORs and fits pretty well in the spi_mem_op representation. > > > > By doing this conversion you'd allow people to connect an AT25 EEPROM > > to an advanced SPI controller that does not support regular SPI > > transfers and you wouldn't have to forge SPI messages manually. > > > > Here is a patch (only compile tested) doing that. The diffstat is not in > > favor of this conversion, but I find the resulting code cleaner and more > > future proof. > > Thanks, seems to work fine, with the 512-byte 25LC040 I have! > > Tested-by: Geert Uytterhoeven <geert+rene...@glider.be> > > I did notice that the first two-byte transfer (command+offset) of each > message is now split in two one-byte transfers, though.
Ok, I'll drop this patch series and wait for the updated version to be sent out :) thanks, greg k-h
