Hi Lee, Pi-Hsun, Missatge de Lee Jones <[email protected]> del dia dc., 30 de gen. 2019 a les 14:07: > > On Mon, 21 Jan 2019, Pi-Hsun Shih wrote: > > > Since a SCP and EC would both exist on a system, and use the cros_ec_dev > > driver, we need to differentiate between them for the userspace, or they > > would both be registered at /dev/cros_ec, causing a conflict. > > > > Cc: Enric Balletbo Serra <[email protected]> > > Cc: Guenter Roeck <[email protected]> > > Signed-off-by: Pi-Hsun Shih <[email protected]> > > --- > > Changes from v2: > > - No change. > > > > Changes from v1: > > - New patch extracted from Patch 5. > > --- > > drivers/mfd/cros_ec_dev.c | 9 +++++++++ > > include/linux/mfd/cros_ec.h | 1 + > > include/linux/mfd/cros_ec_commands.h | 2 ++ > > 3 files changed, 12 insertions(+) > > Just to clarify to the new Cc'ed list, I'm waiting on one of the > Chromium guys to review before I put my mucky paws over it. >
Pi-Hsun, is this patchset still an RFC or you really want to see this merged ASAP? If I am not mistaken there is still some work in progress trying to push all the SCP stuff? Lee, personally I have some concerns. Looks like the cros_* family is increasing quickly lately (cros_ec, cros_pd, cros_scp, cros_ish, cros_fp ...) and I am wondering if we are really doing well all this. To be honest, I'd like to take a deeper look before merge this, btw I thought there was no hurry because of the RFC and I guess there are still some scp things that are missing. I might be wrong, and if that's not the case I can take a look deeper and the end of the week. Best regards, Enric > -- > Lee Jones [李琼斯] > Linaro Services Technical Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog
