Hi Paul,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mtd/nand/next]
[also build test ERROR on v5.0-rc4 next-20190204]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Paul-Cercueil/Ingenic-JZ4780-NAND-patchset-v2/20190204-163709
base:   git://git.infradead.org/linux-mtd.git nand/next
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 8.2.0-11) 8.2.0
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.2.0 make.cross ARCH=sparc64 

All errors (new ones prefixed by >>):

   drivers/mtd/nand/raw/ingenic/jz4740_bch.c: In function 'jz4740_bch_init':
   drivers/mtd/nand/raw/ingenic/jz4740_bch.c:46:2: error: implicit declaration 
of function 'writel' [-Werror=implicit-function-declaration]
     writel(0, bch->base + JZ_REG_NAND_IRQ_STAT);
     ^~~~~~
>> drivers/mtd/nand/raw/ingenic/jz4740_bch.c:49:8: error: implicit declaration 
>> of function 'readl'; did you mean 'd_real'? 
>> [-Werror=implicit-function-declaration]
     reg = readl(bch->base + JZ_REG_NAND_ECC_CTRL);
           ^~~~~
           d_real
   drivers/mtd/nand/raw/ingenic/jz4740_bch.c: In function 
'jz4740_bch_calculate':
   drivers/mtd/nand/raw/ingenic/jz4740_bch.c:83:17: error: implicit declaration 
of function 'readb' [-Werror=implicit-function-declaration]
      ecc_code[i] = readb(bch->base + JZ_REG_NAND_PAR0 + i);
                    ^~~~~
   drivers/mtd/nand/raw/ingenic/jz4740_bch.c: In function 'jz4740_bch_correct':
   drivers/mtd/nand/raw/ingenic/jz4740_bch.c:123:3: error: implicit declaration 
of function 'writeb'; did you mean 'up_write'? 
[-Werror=implicit-function-declaration]
      writeb(ecc_code[i], bch->base + JZ_REG_NAND_PAR0 + i);
      ^~~~~~
      up_write
   cc1: some warnings being treated as errors

vim +49 drivers/mtd/nand/raw/ingenic/jz4740_bch.c

    40  
    41  static void jz4740_bch_init(struct jz4780_bch *bch, bool encode)
    42  {
    43          uint32_t reg;
    44  
    45          /* Clear interrupt status */
  > 46          writel(0, bch->base + JZ_REG_NAND_IRQ_STAT);
    47  
    48          /* Initialize and enable BCH */
  > 49          reg = readl(bch->base + JZ_REG_NAND_ECC_CTRL);
    50          reg |= JZ_NAND_ECC_CTRL_RESET;
    51          reg |= JZ_NAND_ECC_CTRL_ENABLE;
    52          reg |= JZ_NAND_ECC_CTRL_RS;
    53          if (encode)
    54                  reg |= JZ_NAND_ECC_CTRL_ENCODING;
    55          else
    56                  reg &= ~JZ_NAND_ECC_CTRL_ENCODING;
    57  
    58          writel(reg, bch->base + JZ_REG_NAND_ECC_CTRL);
    59  }
    60  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to