Hi Wen, For the next version can you please post a series with the three commits which are fixing the same reference leak? No need to add a cover letter though.
Wen Yang <[email protected]> wrote on Tue, 5 Feb 2019 14:32:41 +0000: > of_find_device_by_node() takes a reference to the struct device > when it finds a match via get_device, there is no need to call > get_device() twice. > We also should make sure to drop the reference to the device > taken by of_find_device_by_node() on driver unbind. > > Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver") > Signed-off-by: Wen Yang <[email protected]> > Suggested-by: Boris Brezillon <[email protected]> > Reviewed-by: Boris Brezillon <[email protected]> > Reviewed-by: Miquel Raynal <[email protected]> > Acked-by: Miquel Raynal <[email protected]> > Cc: Tudor Ambarus <[email protected]> > Cc: Boris Brezillon <[email protected]> > Cc: Miquel Raynal <[email protected]> > Cc: Richard Weinberger <[email protected]> > Cc: David Woodhouse <[email protected]> > Cc: Brian Norris <[email protected]> > Cc: Marek Vasut <[email protected]> > Cc: Nicolas Ferre <[email protected]> > Cc: Alexandre Belloni <[email protected]> > Cc: Ludovic Desroches <[email protected]> > Cc: [email protected] > Cc: [email protected] > Cc: [email protected] > --- > drivers/mtd/nand/raw/atmel/pmecc.c | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/nand/raw/atmel/pmecc.c > b/drivers/mtd/nand/raw/atmel/pmecc.c > index 555a74e..1477368 100644 > --- a/drivers/mtd/nand/raw/atmel/pmecc.c > +++ b/drivers/mtd/nand/raw/atmel/pmecc.c > @@ -876,16 +876,22 @@ static struct atmel_pmecc > *atmel_pmecc_get_by_node(struct device *userdev, > { > struct platform_device *pdev; > struct atmel_pmecc *pmecc, **ptr; > + int ret; > > pdev = of_find_device_by_node(np); > - if (!pdev || !platform_get_drvdata(pdev)) > + if (!pdev) > return ERR_PTR(-EPROBE_DEFER); > + if (!platform_get_drvdata(pdev)) { > + ret = -EPROBE_DEFER; > + goto err_put_device; > + } > > ptr = devres_alloc(devm_atmel_pmecc_put, sizeof(*ptr), GFP_KERNEL); > - if (!ptr) > - return ERR_PTR(-ENOMEM); > + if (!ptr) { > + ret = -ENOMEM; > + goto err_put_device; > + } > > - get_device(&pdev->dev); > pmecc = platform_get_drvdata(pdev); I just realized in the three cases, a first call to platform_get_drvdata() is done to check if the returned pointer is valid, and then a second one is done to actually retrieve the pointer. Please avoid this repetition. Thanks, Miquèl
