On Wed, Feb 06, 2019 at 09:42:48AM +0100, Fabrice Gasnier wrote:
> If you agree with the current approach, I can send a V2 with Tomasz's
> suggestion to remove the ifdefs and use __maybe_unused instead.
I think the suspend callback should have something like:
if (is_still_enabled) {
/*
* The consumer didn't stop us, so refuse to suspend.
*/
dev_err(dev, "The consumer didn't stop us, so refuse to
suspend.\n");
return -EBUSY;
}
This way there are no bad surprises if the pwm is suspended before its
consumer and it's obvious what is missing.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
