From: Razvan Stefanescu <razvan.stefane...@nxp.com>

ethsw_set_learning()/ethsw_set_flood() use flags parameter as an
enable/disable (1/0) indicator. Previous usage sent incorrect values.

Signed-off-by: Razvan Stefanescu <razvan.stefane...@nxp.com>
Signed-off-by: Ioana Ciornei <ioana.cior...@nxp.com>
---
 drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c 
b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
index daabace..9463e05 100644
--- a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
+++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
@@ -676,11 +676,12 @@ static int port_attr_br_flags_set(struct net_device 
*netdev,
                return 0;
 
        /* Learning is enabled per switch */
-       err = ethsw_set_learning(port_priv->ethsw_data, flags & BR_LEARNING);
+       err = ethsw_set_learning(port_priv->ethsw_data,
+                                !!(flags & BR_LEARNING));
        if (err)
                goto exit;
 
-       err = ethsw_port_set_flood(port_priv, flags & BR_FLOOD);
+       err = ethsw_port_set_flood(port_priv, !!(flags & BR_FLOOD));
 
 exit:
        return err;
-- 
1.9.1

Reply via email to