It is well known that because the mm can internally
call the regular gup_unlocked if the lockless approach
fails and take the sem there, the caller must not hold
the mmap_sem already.

Fixes: e523f289fe4d (MIPS: c-r4k: Fix sigtramp SMP call to use kmap)
Cc: Ralf Baechle <r...@linux-mips.org>
Cc: Paul Burton <paul.bur...@mips.com>
Cc: James Hogan <jho...@kernel.org>
Cc: linux-m...@vger.kernel.org
Signed-off-by: Davidlohr Bueso <dbu...@suse.de>
---
 arch/mips/mm/c-r4k.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/mips/mm/c-r4k.c b/arch/mips/mm/c-r4k.c
index cc4e17caeb26..38fe86928837 100644
--- a/arch/mips/mm/c-r4k.c
+++ b/arch/mips/mm/c-r4k.c
@@ -1034,11 +1034,9 @@ static void r4k_flush_cache_sigtramp(unsigned long addr)
        struct flush_cache_sigtramp_args args;
        int npages;
 
-       down_read(&current->mm->mmap_sem);
-
        npages = get_user_pages_fast(addr, 1, 0, &args.page);
        if (npages < 1)
-               goto out;
+               return;
 
        args.mm = current->mm;
        args.addr = addr;
@@ -1046,8 +1044,6 @@ static void r4k_flush_cache_sigtramp(unsigned long addr)
        r4k_on_each_cpu(R4K_HIT, local_r4k_flush_cache_sigtramp, &args);
 
        put_page(args.page);
-out:
-       up_read(&current->mm->mmap_sem);
 }
 
 static void r4k_flush_icache_all(void)
-- 
2.16.4

Reply via email to