On 24/01/2019 09:07, Erin Lo wrote:
> From: Seiya Wang <[email protected]>
> 
> To support partitioned PPIs, 4 interrupt parameters should be valid
> for sysirq.
> 
> Signed-off-by: Seiya Wang <[email protected]>
> Signed-off-by: Erin Lo <[email protected]>
> ---
>  drivers/irqchip/irq-mtk-sysirq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-mtk-sysirq.c 
> b/drivers/irqchip/irq-mtk-sysirq.c
> index 90aaf19..282736a 100644
> --- a/drivers/irqchip/irq-mtk-sysirq.c
> +++ b/drivers/irqchip/irq-mtk-sysirq.c
> @@ -81,7 +81,7 @@ static int mtk_sysirq_domain_translate(struct irq_domain *d,
>                                      unsigned int *type)
>  {
>       if (is_of_node(fwspec->fwnode)) {
> -             if (fwspec->param_count != 3)
> +             if (fwspec->param_count != 3 && fwspec->param_count != 4)

Where is this 4th parameter used?

Regards,
Matthias

>                       return -EINVAL;
>  
>               /* No PPI should point to this domain */
> @@ -104,7 +104,7 @@ static int mtk_sysirq_domain_alloc(struct irq_domain 
> *domain, unsigned int virq,
>       struct irq_fwspec *fwspec = arg;
>       struct irq_fwspec gic_fwspec = *fwspec;
>  
> -     if (fwspec->param_count != 3)
> +     if (fwspec->param_count != 3 && fwspec->param_count != 4)
>               return -EINVAL;
>  
>       /* sysirq doesn't support PPI */
> 

Reply via email to