On Thu, Feb 7, 2019 at 2:32 PM Sven Van Asbroeck <thesve...@gmail.com> wrote:
>
> On Thu, Feb 7, 2019 at 5:21 PM Dmitry Torokhov
> <dmitry.torok...@gmail.com> wrote:
> >
> > > ./drivers//input/keyboard/matrix_keypad.c:512:1-18: missing clean-up
> > > of INIT_WORK/INIT_DELAYED_WORK initialized here
> >
> > This is not as simple.
> >
>
> PS If you change
> flush_work(&keypad->work.work);
> to
> flush_delayed_work(&keypad->work);
>
> then the Coccinelle script works correctly, and does not flag
> this driver.

Yes, I just sent out the patch as it was in fact a bug: we could have
missed work that is scheduled but not queued.

-- 
Dmitry

Reply via email to