Hi John, On 1/3/2019 11:57 AM, John Garry wrote: > Currently for ACPI-based FW we fail the probe for an unrecognised child > HID. > > However, there is FW in the field with LPC child devices having fake HIDs, > namely "IPI0002", which was an IPMI device invented to support the > initial out-of-tree LPC host driver, different from the final mainline > version. > > To provide compatibility support for these dodgy FWs, just discard the > unrecognised HIDs instead of failing the probe altogether. > > Tested-by: Zengruan Ye <yezengr...@huawei.com> > Signed-off-by: John Garry <john.ga...@huawei.com>
Updated the subject as "bus: hisi_lpc: xxx" to follow the style and applied to the hisilicon tree. Thanks! Best Regards, Wei > > diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c > index d5f8545..19d7b6f 100644 > --- a/drivers/bus/hisi_lpc.c > +++ b/drivers/bus/hisi_lpc.c > @@ -522,10 +522,9 @@ static int hisi_lpc_acpi_probe(struct device *hostdev) > > if (!found) { > dev_warn(hostdev, > - "could not find cell for child device (%s)\n", > + "could not find cell for child device (%s), > discarding\n", > hid); > - ret = -ENODEV; > - goto fail; > + continue; > } > > pdev = platform_device_alloc(cell->name, PLATFORM_DEVID_AUTO); >