On Fri, Feb 08, 2019 at 09:02:22AM -0500, Stefan Berger wrote:
> On 2/8/19 8:33 AM, Jarkko Sakkinen wrote:
> >
> > if (len != be32_to_cpu(header->length)) {
> > rc = -EFAULT;
> > goto out;
> > }
> >
> > rc = tpm2_commit_space(chip, space, ordinal, buf, &len);
> > if (rc)
> > dev_err(&chip->dev, "tpm2_commit_space: error %d\n", rc);
> >
> > That unconditional call to commit space masked the bugs in the device
> > drivers. I'll provide fixes shortly.
>
> You got it! :-)
Yes, and it should not be fixes in tpm-interface.c. Sent a patch set
for review.
Thanks for spotting this out!
/Jarkko
