On Wed, 6 Feb 2019 20:00:13 +0100 Andreas Ziegler <andreas.zieg...@fau.de> wrote:
> Commit 9178412ddf5a ("tracing: probeevent: Return consumed > bytes of dynamic area") improved the string fetching > mechanism by returning the number of required bytes after > copying the argument to the dynamic area. However, this > return value is now only used to increment the pointer > inside the dynamic area but misses updating the 'maxlen' > variable which indicates the remaining space in the dynamic > area. > > This means that fetch_store_string() always reads the *total* > size of the dynamic area from the data_loc pointer instead of > the *remaining* size (and passes it along to > strncpy_from_{user,unsafe}) even if we're already about to > copy data into the middle of the dynamic area. > > Fixes: 9178412ddf5a ("tracing: probeevent: Return consumed bytes of dynamic > area") > Signed-off-by: Andreas Ziegler <andreas.zieg...@fau.de> > Acked-by: Masami Hiramatsu <mhira...@kernel.org> > --- > I applied it and will start testing it. But just an FYI, please send new versions of a patch as a separate thread. Sending it as a reply to is likely to have it get missed, as maintainers usually search their inboxes threaded, and only look at patches that are the start of a thread. I just happened to have this one marked to look at. -- Steve