On Tue, 12 Feb 2019 09:31:31 -0600 "Gustavo A. R. Silva" <gust...@embeddedor.com> wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/mtd/lpddr/lpddr_cmds.c: In function ‘chip_ready’: > drivers/mtd/lpddr/lpddr_cmds.c:319:6: warning: this statement may fall > through [-Wimplicit-fallthrough=] > if (mode == FL_READY && chip->oldstate == FL_READY) > ^ > drivers/mtd/lpddr/lpddr_cmds.c:322:2: note: here > default: > ^~~~~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > You sent me that one twice, is that expected? Is this a new version, and in that case, what has changed? > Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com> > --- > drivers/mtd/lpddr/lpddr_cmds.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/lpddr/lpddr_cmds.c b/drivers/mtd/lpddr/lpddr_cmds.c > index b13557fe52bd..76a4c73e100e 100644 > --- a/drivers/mtd/lpddr/lpddr_cmds.c > +++ b/drivers/mtd/lpddr/lpddr_cmds.c > @@ -318,6 +318,7 @@ static int chip_ready(struct map_info *map, struct flchip > *chip, int mode) > /* Only if there's no operation suspended... */ > if (mode == FL_READY && chip->oldstate == FL_READY) > return 0; > + /* fall through */ > > default: > sleep:
