śr., 13 lut 2019 o 14:15 Baolin Wang <baolin.w...@linaro.org> napisał(a):
>
> On Wed, 13 Feb 2019 at 20:59, Bartosz Golaszewski
> <bgolaszew...@baylibre.com> wrote:
> >
> > śr., 13 lut 2019 o 13:49 Baolin Wang <baolin.w...@linaro.org> napisał(a):
> > >
> > > Change to use SoC compatible string instead of wildcard string.
> > >
> > > Signed-off-by: Baolin Wang <baolin.w...@linaro.org>
> > > ---
> > > drivers/gpio/gpio-pmic-eic-sprd.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c
> > > b/drivers/gpio/gpio-pmic-eic-sprd.c
> > > index ac573da..24228cf 100644
> > > --- a/drivers/gpio/gpio-pmic-eic-sprd.c
> > > +++ b/drivers/gpio/gpio-pmic-eic-sprd.c
> > > @@ -364,7 +364,7 @@ static int sprd_pmic_eic_probe(struct platform_device
> > > *pdev)
> > > }
> > >
> > > static const struct of_device_id sprd_pmic_eic_of_match[] = {
> > > - { .compatible = "sprd,sc27xx-eic", },
> > > + { .compatible = "sprd,sc2731-eic", },
> > > { /* end of list */ }
> > > };
> > > MODULE_DEVICE_TABLE(of, sprd_pmic_eic_of_match);
> > > --
> > > 1.7.9.5
> > >
> >
> > We guarantee to make older device-trees to work with new kernel so you
> > can add the new compatible, but you can't remove the old one.
>
> But the old one is incorrect, and we still keep it?
>
Well in theory the device-tree is supposed to be a stable ABI so once
it's released, it should work with any following kernel version.
In practice changes are sometimes allowed and there are also bugs in DT files.
Linus: what do you think?
Bart
