On Wed, Feb 13, 2019 at 06:18:17PM +0100, Marc Gonzalez wrote:
> On 13/02/2019 17:47, Randy Dunlap wrote:
>
> > seen on i386:
> >
> > when CONFIG_IRQ_DOMAIN_HIERARCHY is not enabled:
> >
> > ../drivers/spmi/spmi-pmic-arb.c:1154:2: error: unknown field ‘activate’
> > specified in initializer
> > .activate = qpnpint_irq_domain_activate,
> > ^
> > ../drivers/spmi/spmi-pmic-arb.c:1154:2: warning: initialization from
> > incompatible pointer type [enabled by default]
> > ../drivers/spmi/spmi-pmic-arb.c:1154:2: warning: (near initialization for
> > ‘pmic_arb_irq_domain_ops.match’) [enabled by default]
> > ../drivers/spmi/spmi-pmic-arb.c:1155:2: error: unknown field ‘alloc’
> > specified in initializer
> > .alloc = qpnpint_irq_domain_alloc,
> > ^
> > ../drivers/spmi/spmi-pmic-arb.c:1155:2: warning: initialization from
> > incompatible pointer type [enabled by default]
> > ../drivers/spmi/spmi-pmic-arb.c:1155:2: warning: (near initialization for
> > ‘pmic_arb_irq_domain_ops.select’) [enabled by default]
> > ../drivers/spmi/spmi-pmic-arb.c:1156:2: error: unknown field ‘free’
> > specified in initializer
> > .free = irq_domain_free_irqs_common,
> > ^
> > ../drivers/spmi/spmi-pmic-arb.c:1156:10: error:
> > ‘irq_domain_free_irqs_common’ undeclared here (not in a function)
> > .free = irq_domain_free_irqs_common,
> > ^
> > ../drivers/spmi/spmi-pmic-arb.c:1157:2: error: unknown field ‘translate’
> > specified in initializer
> > .translate = qpnpint_irq_domain_translate,
> > ^
> > ../drivers/spmi/spmi-pmic-arb.c:1157:2: warning: initialization from
> > incompatible pointer type [enabled by default]
> > ../drivers/spmi/spmi-pmic-arb.c:1157:2: warning: (near initialization for
> > ‘pmic_arb_irq_domain_ops.unmap’) [enabled by default]
drivers/pinctrl/qcom/Kconfig already has this in linux-next:
config PINCTRL_QCOM_SPMI_PMIC
tristate "Qualcomm SPMI PMIC pin controller driver"
...
select IRQ_DOMAIN_HIERARCHY
Am I missing something else?
Brian
