> -----Original Message-----
> From: Bo YU <tsu.y...@gmail.com>
> Sent: Thursday, February 14, 2019 12:46 PM
> To: Deucher, Alexander <alexander.deuc...@amd.com>; Koenig, Christian
> <christian.koe...@amd.com>; Zhou, David(ChunMing)
> <david1.z...@amd.com>; airl...@linux.ie; dan...@ffwll.ch; Zhu, Rex
> <rex....@amd.com>; Grodzovsky, Andrey
> <andrey.grodzov...@amd.com>; dri-de...@lists.freedesktop.org; linux-
> ker...@vger.kernel.org
> Cc: Bo Yu <tsu.y...@gmail.com>; amd-...@lists.freedesktop.org
> Subject: [PATCH] drm/amdgpu: Error handling issues about
> CHECKED_RETURN
>
> From: Bo Yu <tsu.y...@gmail.com>
>
> Calling "amdgpu_ring_test_helper" without checking return value
We could need to continue to ring test even there is one ring test failed.
-David
>
> Signed-off-by: Bo Yu <tsu.y...@gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> index 57cb3a51bda7..48465a61516b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> @@ -4728,7 +4728,9 @@ static int gfx_v8_0_cp_test_all_rings(struct
> amdgpu_device *adev)
>
> for (i = 0; i < adev->gfx.num_compute_rings; i++) {
> ring = &adev->gfx.compute_ring[i];
> - amdgpu_ring_test_helper(ring);
> + r = amdgpu_ring_test_helper(ring);
> + if (r)
> + return r;
> }
>
> return 0;
> --
> 2.11.0
