If it fails to read a shared xattr page, the inode's shared xattr array
is not freed. The next time the inode's xattr is accessed, the previously
allocated array is leaked.

Signed-off-by: Sheng Yong <shengyo...@huawei.com>
---
v2: * s/node/inode in commit message
    * add prefix `staging:' to the subject
---
 drivers/staging/erofs/xattr.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/erofs/xattr.c b/drivers/staging/erofs/xattr.c
index 80dca6a4adbe..e3f8b904a680 100644
--- a/drivers/staging/erofs/xattr.c
+++ b/drivers/staging/erofs/xattr.c
@@ -92,8 +92,11 @@ static int init_inode_xattrs(struct inode *inode)
 
                        it.page = erofs_get_meta_page(sb,
                                ++it.blkaddr, S_ISDIR(inode->i_mode));
-                       if (IS_ERR(it.page))
+                       if (IS_ERR(it.page)) {
+                               kfree(vi->xattr_shared_xattrs);
+                               vi->xattr_shared_xattrs = NULL;
                                return PTR_ERR(it.page);
+                       }
 
                        it.kaddr = kmap_atomic(it.page);
                        atomic_map = true;
-- 
2.17.1

Reply via email to