On Thu, Feb 14, 2019 at 08:18:49AM +0000, Lee Jones wrote:
> On Wed, 13 Feb 2019, Guenter Roeck wrote:
>
> > On 2/13/19 5:37 AM, Matti Vaittinen wrote:
> > > Initial support for watchdog block included in ROHM BD70528
> > > power management IC.
> > >
> > > Configurations for low power states are still to be checked.
> > >
> > > Signed-off-by: Matti Vaittinen <[email protected]>
> > > Acked-by: Guenter Roeck <[email protected]>
> > > ---
> > >
> > > I maintained the ack from Guenter as only change is to use function
> > > exported by MFD instead of pointer to function provided by MFD. Please
> > > let me know if this is not Ok.
> > >
> >
> > NP. With functions exported by MFD, my choice would have been to handle
> > locking there as well with respective locking/unlocking functions exported.
> > But that is your call to make, not mine.
>
> FWIW, I agree.
Allright. I'll do lock/unclock functions in MFD side and cook up v10 =)
Linus Walleij found something to fix from GPIO too :) Thanks guys.
Br,
Matti Vaittinen
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~