Re: [PATCH 7/8] ARM: dts: stm32: Add Ethernet support on stm32h7 SOC and activate it for eval and disco boards

[Christophe ROULLIER]

On 2/14/19 2:44 PM, Andrew Lunn wrote:
> On Thu, Feb 14, 2019 at 07:46:02AM +0100, Christophe Roullier wrote:
>> +    mdio0 {
>> +            #address-cells = <1>;
>> +            #size-cells = <0>;
>> +            compatible = "snps,dwmac-mdio";
>> +            phy1: ethernet-phy@1 {
>> +                    reg = <0>;
>> +            };
> 
> The reg value should be the same as ethernet-phy@X.
> 
>      Andrew
>> +    mdio0 {
>> +            #address-cells = <1>;
>> +            #size-cells = <0>;
>> +            compatible = "snps,dwmac-mdio";
>> +            phy1: ethernet-phy@1 {
>> +                    reg = <0>;
>> +            };
> 
> Here as well.
> 
>       Andrew
> 

Hi Andrew,

Ok I will update.

Thanks.

Christophe