On Fri, Feb 15, 2019 at 01:53:48PM -0800, Song Liu wrote:

SNIP

> @@ -165,6 +179,19 @@ static int perf_event__synthesize_one_bpf_prog(struct 
> perf_tool *tool,
>               memcpy(bpf_event->tag, info->tag, BPF_TAG_SIZE);
>               memset((void *)event + event->header.size, 0, 
> machine->id_hdr_size);
>               event->header.size += machine->id_hdr_size;
> +
> +             /* save bpf_prog_info to env */
> +             info_node = malloc(sizeof(struct bpf_prog_info_node));
> +             if (info_node) {
> +                     info_node->info_linear = info_linear;
> +                     perf_env__insert_bpf_prog_info(env, info_node);
> +                     info_linear = NULL;
> +             }
> +
> +             /*
> +              * process after saving bpf_prog_info to env, so that
> +              * required information is ready for look up
> +              */
>               err = perf_tool__process_synth_event(tool, event,
>                                                    machine, process);
>       }
> @@ -175,7 +202,7 @@ static int perf_event__synthesize_one_bpf_prog(struct 
> perf_tool *tool,
>       return err ? -1 : 0;
>  }
>  
> -int perf_event__synthesize_bpf_events(struct perf_tool *tool,
> +int perf_event__synthesize_bpf_events(struct perf_session *session,
>                                     perf_event__handler_t process,
>                                     struct machine *machine,
>                                     struct record_opts *opts)

please move the prototype change into separate patch

thanks,
jirka

Reply via email to