RE: [PATCH V2 0/4] Add i.MX8QXP system controller watchdog support

[Anson Huang]

Hi, Guenter

Best Regards!
Anson Huang

> -----Original Message-----
> From: Guenter Roeck [mailto:groe...@gmail.com] On Behalf Of Guenter
> Roeck
> Sent: 2019年2月18日 13:16
> To: Anson Huang <anson.hu...@nxp.com>; robh...@kernel.org;
> mark.rutl...@arm.com; shawn...@kernel.org; s.ha...@pengutronix.de;
> ker...@pengutronix.de; feste...@gmail.com; catalin.mari...@arm.com;
> will.dea...@arm.com; w...@linux-watchdog.org; Aisheng Dong
> <aisheng.d...@nxp.com>; ulf.hans...@linaro.org; Daniel Baluta
> <daniel.bal...@nxp.com>; Andy Gross <andy.gr...@linaro.org>;
> horms+rene...@verge.net.au; he...@sntech.de; a...@arndb.de;
> bjorn.anders...@linaro.org; ja...@amarulasolutions.com;
> enric.balle...@collabora.com; marc.w.gonza...@free.fr; o...@lixom.net;
> devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-
> ker...@lists.infradead.org; linux-watch...@vger.kernel.org
> Cc: dl-linux-imx <linux-...@nxp.com>
> Subject: Re: [PATCH V2 0/4] Add i.MX8QXP system controller watchdog
> support
> 
> On 2/17/19 6:01 PM, Anson Huang wrote:
> > i.MX8QXP is an ARMv8 Cortex-A35 SoC with a Cortex-M4 system controller
> > inside, the system controller manages overall power, clock, secure RTC
> > and watchdog etc., so Linux kernel running on A35 needs to communicate
> > with system controller for watchdog operation, this system controller
> > watchdog will call SMC to trap to EL3 secure world
> > ARM-Trusted-Firmware and then it will request system controller to do the
> watchdog operation via IPC.
> >
> >
> And you expect I'll spend the time comparing this version of the patch series
> against version 1 and figure out myself what exactly changed ?
> 
> Guenter

Sorry, I planned to reply your review mail but forgot, I addressed all your 
comments
in V2 patch set, I will add the change log in V2 watchdog driver patch and 
resend.

Anson.

> 
> Below are the patch dependency:
> >
> > The dt-binding and imx8qxp.dtsi patch are based on my thermal patch
> series as below:
> >
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpat
> >
> chwork.kernel.org%2Fpatch%2F10800699%2F&amp;data=02%7C01%7Canso
> n.huang
> > %40nxp.com%7C630e6c5d7ed04a912f7708d695603cb2%7C686ea1d3bc2b4
> c6fa92cd9
> >
> 9c5c301635%7C0%7C0%7C636860637903984268&amp;sdata=a25qJs%2Fb4e
> 2a9Ey77U
> > gTNKAGCQ8IWRcUKb4G0lK%2Bkjc%3D&amp;reserved=0
> >
> > Anson Huang (4):
> >    dt-bindings: fsl: scu: add watchdog binding
> >    watchdog: imx_sc: Add i.MX system controller watchdog support
> >    arm64: defconfig: add support for i.MX system controller watchdog
> >    arm64: dts: freescale: imx8qxp: add watchdog support
> >
> >   .../devicetree/bindings/arm/freescale/fsl,scu.txt  |  10 +
> >   arch/arm64/boot/dts/freescale/imx8qxp.dtsi         |   4 +
> >   arch/arm64/configs/defconfig                       |   1 +
> >   drivers/watchdog/Kconfig                           |  13 ++
> >   drivers/watchdog/Makefile                          |   1 +
> >   drivers/watchdog/imx_sc_wdt.c                      | 210
> +++++++++++++++++++++
> >   6 files changed, 239 insertions(+)
> >   create mode 100644 drivers/watchdog/imx_sc_wdt.c
> >