On Mon, Feb 18, 2019 at 8:46 PM Zhiyong Tao <zhiyong....@mediatek.com> wrote: > > On Mon, 2019-02-18 at 10:32 -0600, Rob Herring wrote: > > On Fri, Feb 15, 2019 at 02:02:35PM +0800, Erin Lo wrote: > > > From: Zhiyong Tao <zhiyong....@mediatek.com> > > > > > > The commit adds mt8183 compatible node in binding document. > > > > > > Signed-off-by: Zhiyong Tao <zhiyong....@mediatek.com> > > > Signed-off-by: Erin Lo <erin...@mediatek.com> > > > --- > > > .../devicetree/bindings/pinctrl/pinctrl-mt8183.txt | 115 > > > +++++++++++++++++++++ > > > 1 file changed, 115 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/pinctrl/pinctrl-mt8183.txt > > > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8183.txt > > > b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8183.txt > > > new file mode 100644 > > > index 0000000..364e673 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8183.txt > > > @@ -0,0 +1,115 @@ > > > +* Mediatek MT8183 Pin Controller > > > + > > > +The Mediatek's Pin controller is used to control SoC pins. > > > + > > > +Required properties: > > > +- compatible: value should be one of the following. > > > + "mediatek,mt8183-pinctrl", compatible with mt8183 pinctrl. > > > +- gpio-controller : Marks the device node as a gpio controller. > > > +- #gpio-cells: number of cells in GPIO specifier. Since the generic GPIO > > > + binding is used, the amount of cells must be specified as 2. See the > > > below > > > + mentioned gpio binding representation for description of particular > > > cells. > > > +- gpio-ranges : gpio valid number range. > > > +- reg: physicall address base for gpio base registers. There are nine > > > + physicall address base in mt8183. They are 0x10005000, 0x11F20000, > > > + 0x11E80000, 0x11E70000, 0x11E90000, 0x11D30000, 0x11D20000, 0x11C50000, > > > + 0x11F30000. > > > > You don't need to list out each address, just what each address is. (Or > > just '9 GPIO base addresses'.) > > ==>ok, we will change it. > > > > > + > > > + Eg: <&pio 6 0> > > > > How is this an example of reg? Seems something is missing. > > > > > + <[phandle of the gpio controller node] > > > + [line number within the gpio controller] > > > + [flags]> > > > + > > > + Values for gpio specifier: > > > + - Line number: is a value between 0 to 202. > > > + - Flags: bit field of flags, as defined in <dt-bindings/gpio/gpio.h>. > > > + Only the following flags are supported: > > > + 0 - GPIO_ACTIVE_HIGH > > > + 1 - GPIO_ACTIVE_LOW > > > + > > > +Optional properties: > > > +- reg-names: gpio base register names. There are nine gpio base register > > > + names in mt8183. They are "iocfg0", "iocfg1", "iocfg2", "iocfg3", > > > "iocfg4", > > > + "iocfg5", "iocfg6", "iocfg7", "iocfg8". > > > +- interrupt-controller: Marks the device node as an interrupt controller > > > +- #interrupt-cells: Should be two. > > > +- interrupts : The interrupt outputs from the controller. > > > > outputs? More than 1? If so, need to say what they are and the order. > > > ==> there is only use one interrupt in mt8183. we will change > "interrupts" to "interrupt" in v8.
No, 'interrupts' is always plural. The problem is 'outputs'. Rob
