From: John Zhao <yuank...@codeaurora.org>

When no file /path was found, the error code of -ENOENT
enumerated in errno-base.h, is returned. Stating clearly that
the file was not found is much more useful for debugging, So
let's be explicit about that.

Signed-off-by: John Zhao <yuank...@codeaurora.org>
---
 drivers/base/firmware_loader/main.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c
index 8e9213b..7eaaf5e 100644
--- a/drivers/base/firmware_loader/main.c
+++ b/drivers/base/firmware_loader/main.c
@@ -328,12 +328,12 @@ fw_get_filesystem_firmware(struct device *device, struct fw_priv *fw_priv)
                rc = kernel_read_file_from_path(path, &fw_priv->data, &size,
                                                msize, id);
                if (rc) {
-                       if (rc == -ENOENT)
-                               dev_dbg(device, "loading %s failed with error 
%d\n",
-                                        path, rc);
-                       else
+                       if (rc != -ENOENT)
                                dev_warn(device, "loading %s failed with error 
%d\n",
                                         path, rc);
+                       else
+ dev_dbg(device, "loading %s failed for no such file or directory.\n",
+                                        path);
                        continue;
                }
                dev_dbg(device, "direct-loading %s\n", fw_priv->fw_name);
--

Reply via email to