From: Nadav Amit <na...@vmware.com>

There is no apparent reason not to use text_poke_early() during
early-init, since no patching of code that might be on the stack is done
and only a single core is running.

This is required for the next patches that would set a temporary mm for
text poking, and this mm is only initialized after some static-keys are
enabled/disabled.

Cc: Andy Lutomirski <l...@kernel.org>
Cc: Kees Cook <keesc...@chromium.org>
Cc: Dave Hansen <dave.han...@intel.com>
Cc: Masami Hiramatsu <mhira...@kernel.org>
Acked-by: Peter Zijlstra (Intel) <pet...@infradead.org>
Signed-off-by: Nadav Amit <na...@vmware.com>
Signed-off-by: Rick Edgecombe <rick.p.edgeco...@intel.com>
---
 arch/x86/kernel/jump_label.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kernel/jump_label.c b/arch/x86/kernel/jump_label.c
index f99bd26bd3f1..e7d8c636b228 100644
--- a/arch/x86/kernel/jump_label.c
+++ b/arch/x86/kernel/jump_label.c
@@ -50,7 +50,12 @@ static void __ref __jump_label_transform(struct jump_entry 
*entry,
        jmp.offset = jump_entry_target(entry) -
                     (jump_entry_code(entry) + JUMP_LABEL_NOP_SIZE);
 
-       if (early_boot_irqs_disabled)
+       /*
+        * As long as only a single processor is running and the code is still
+        * not marked as RO, text_poke_early() can be used; Checking that
+        * system_state is SYSTEM_BOOTING guarantees it.
+        */
+       if (system_state == SYSTEM_BOOTING)
                poker = text_poke_early;
 
        if (type == JUMP_LABEL_JMP) {
-- 
2.17.1

Reply via email to